fix: ensure tool calls still work with completions api#415
Closed
kauffinger wants to merge 3 commits intoprism-php:mainfrom
Closed
fix: ensure tool calls still work with completions api#415kauffinger wants to merge 3 commits intoprism-php:mainfrom
kauffinger wants to merge 3 commits intoprism-php:mainfrom
Conversation
Contributor
|
I'll merge #408 today |
Contributor
Author
|
perfect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried 70.1 today in prod and realized tool calls don't work. Quickly rolled back all changes from #256 by using the same pattern as with the
ChatMessageMapin #409Depending on how quick we are with #408 this might be worth merging in between.